Skip to content

Fix InitialCondition restart velocity wrapping#1182

Closed
svchb wants to merge 2 commits into
trixi-framework:mainfrom
svchb:fix/initial-condition-final-velocity
Closed

Fix InitialCondition restart velocity wrapping#1182
svchb wants to merge 2 commits into
trixi-framework:mainfrom
svchb:fix/initial-condition-final-velocity

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented May 12, 2026

No description provided.

@svchb svchb self-assigned this May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.90%. Comparing base (7e43937) to head (d1c7b08).

Files with missing lines Patch % Lines
test/general/initial_condition.jl 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
- Coverage   89.92%   89.90%   -0.02%     
==========================================
  Files         132      132              
  Lines       10434    10445      +11     
==========================================
+ Hits         9383     9391       +8     
- Misses       1051     1054       +3     
Flag Coverage Δ
total 89.90% <75.00%> (-0.02%) ⬇️
unit 70.73% <75.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb added the bug Something isn't working label May 12, 2026
@svchb svchb requested a review from efaulhaber May 12, 2026 11:14
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an oddly specific test for one very specific typo. I don't think that makes sense. This fix is also included in #1101.

@svchb svchb closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants